Forum Discussion

peterlu's avatar
peterlu
Champion
11 years ago

Lithium html markup change

Hi Lithium Dev,   We have noticed that recently your team has been updating a lot of HTML at the layout level. And it breaks 90% of my customers community. Please be careful of doing so, coz these...
  • DougS's avatar
    DougS
    11 years ago

    Hi Peter,

     

    I spoke with the development team that made this change and they are going to change the markup so the new div tag they added gets moved inside of the top div.lia-quilt for the page so the selector you pointed out will continue to work.  We also think that as a general rule, we shouldn't be adding html around that top-most div.lia-quilt.  

     

    However, we do need the ability to add new markup to the page in order to add new features and functionality to the community.  We won't (intentionally) remove elements, change class names, or change the order that class names should come in css selectors, but we sometimes need to wrap pre-existing tags in other tags, so selectors that use the child combinator selector (div.lia-content > div.lia-quilt) are dangerous to use because they may stop working when we place additional markup around already-existing markup on a page.

     

    -Doug

peterlu's avatar
peterlu
Champion

On the edit message page, originally Lithium have 

div.lia-content > div.lia-quilt

 

In the new version, Lithium added in 

div.lia-content > div[data-message-id="3215"] > div.lia-quilt

 

If our customers css are like 

#lia-body .lia-content > .lia-quilt > blablabla

then it is gonna break.

 

My question is why don't add the data-message-id into div.lia-quilt? This way no html layout is changed.

DougS's avatar
DougS
Khoros Oracle
11 years ago

Hi Peter,

 

I spoke with the development team that made this change and they are going to change the markup so the new div tag they added gets moved inside of the top div.lia-quilt for the page so the selector you pointed out will continue to work.  We also think that as a general rule, we shouldn't be adding html around that top-most div.lia-quilt.  

 

However, we do need the ability to add new markup to the page in order to add new features and functionality to the community.  We won't (intentionally) remove elements, change class names, or change the order that class names should come in css selectors, but we sometimes need to wrap pre-existing tags in other tags, so selectors that use the child combinator selector (div.lia-content > div.lia-quilt) are dangerous to use because they may stop working when we place additional markup around already-existing markup on a page.

 

-Doug